feat[next][dace]: Add more debug info to DaCe #1384
Conversation
…tir, and from itir to the SDFG): WIP
…tir, and from itir to the SDFG): WIP
…tir, and from itir to the SDFG)
…tir, and from itir to the SDFG)
There was a problem hiding this comment.
The PR is pretty straightforward (that's a good thing), I left a few comments, but other than that I think there isn't much to change.
However, one thing I'm really missing is tests or any way to ensure that location info is properly transmitted. For example, if someone writes a new iterator IR pass and they don't pass the location, we won't know until somebody tries to look at the generated SDFGs while doing something else. That may be weeks or months down the line and finding the culprit causing the loss of location info will be difficult and annoying.
If you make the location field mandatory in iterator IR, that would do the trick. You could also enforce that location is not None in the SDFG generation, though that's less clear. You could also add a test that verifies if the SDFG has debug info.
…tir, and from itir to the SDFG): WIP
…tir, and from itir to the SDFG): WIP
…tir, and from itir to the SDFG): WIP
FYI, I have integrated Peter's comments in my PR. Some tests are failing because they need this modification from DaCe's side: spcl/dace#1469 cc: @havogt @tehrengruber |
…tir, and from itir to the SDFG): WIP
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
…tir, and from itir to the SDFG): Preserve Location through Visitors [WIP]
|
FYI, all the comments have been integrated in the PR and now all the tests are passing. |
src/gt4py/next/program_processors/runners/dace_iterator/utility.py
Outdated
Show resolved
Hide resolved
…tir, and from itir to the SDFG): Preserve Location through Visitors
…tir, and from itir to the SDFG): Preserve Location through Visitors
…tir, and from itir to the SDFG): Preserve Location through Visitors
…tir, and from itir to the SDFG): Preserve Location through Visitors
…tir, and from itir to the SDFG): Preserve Location through Visitors
…tir, and from itir to the SDFG): Preserve Location through Visitors
…tir, and from itir to the SDFG): Preserve Location through Visitors
…tir, and from itir to the SDFG): Preserve Location through Visitors
kotsaloscv
dismissed
petiaccja’s stale review
already resolved after discussions
Description
Add more debug info to DaCe (pass SourceLocation from past/foast to itir, and from itir to the SDFG)